整理代码

parser/trojan.go

@@ -1,118 +1,155 @@
 package parser
 
 import (
-	"errors"
 	"net/url"
-	"strconv"
 	"strings"
+	"sub2sing-box/constant"
 	"sub2sing-box/model"
 )
 
 func ParseTrojan(proxy string) (model.Outbound, error) {
-	if !strings.HasPrefix(proxy, "trojan://") {
-		return model.Outbound{}, errors.New("invalid trojan Url")
+	if !strings.HasPrefix(proxy, constant.TrojanPrefix) {
+		return model.Outbound{}, &ParseError{Type: ErrInvalidPrefix, Raw: proxy}
 	}
-	parts := strings.SplitN(strings.TrimPrefix(proxy, "trojan://"), "@", 2)
-	if len(parts) != 2 {
-		return model.Outbound{}, errors.New("invalid trojan Url")
+
+	proxy = strings.TrimPrefix(proxy, constant.TrojanPrefix)
+	urlParts := strings.SplitN(proxy, "@", 2)
+	if len(urlParts) != 2 {
+		return model.Outbound{}, &ParseError{
+			Type:    ErrInvalidStruct,
+			Message: "missing character '@' in url",
+			Raw:     proxy,
+		}
 	}
-	serverInfo := strings.SplitN(parts[1], "#", 2)
+	password := strings.TrimSpace(urlParts[0])
+
+	serverInfo := strings.SplitN(urlParts[1], "#", 2)
 	serverAndPortAndParams := strings.SplitN(serverInfo[0], "?", 2)
+	if len(serverAndPortAndParams) != 2 {
+		return model.Outbound{}, &ParseError{
+			Type:    ErrInvalidStruct,
+			Message: "missing character '?' in url",
+			Raw:     proxy,
+		}
+	}
+
 	serverAndPort := strings.SplitN(serverAndPortAndParams[0], ":", 2)
+	if len(serverAndPort) != 2 {
+		return model.Outbound{}, &ParseError{
+			Type:    ErrInvalidStruct,
+			Message: "missing server host or port",
+			Raw:     proxy,
+		}
+	}
+	server, portStr := serverAndPort[0], serverAndPort[1]
+
 	params, err := url.ParseQuery(serverAndPortAndParams[1])
 	if err != nil {
-		return model.Outbound{}, err
+		return model.Outbound{}, &ParseError{
+			Type:    ErrCannotParseParams,
+			Raw:     proxy,
+			Message: err.Error(),
+		}
 	}
-	if len(serverAndPort) != 2 {
-		return model.Outbound{}, errors.New("invalid trojan Url")
-	}
-	port, err := strconv.Atoi(strings.TrimSpace(serverAndPort[1]))
+
+	port, err := ParsePort(portStr)
 	if err != nil {
 		return model.Outbound{}, err
 	}
+
 	remarks := ""
 	if len(serverInfo) == 2 {
 		remarks, _ = url.QueryUnescape(strings.TrimSpace(serverInfo[1]))
 	} else {
 		remarks = serverAndPort[0]
 	}
-	server := strings.TrimSpace(serverAndPort[0])
-	password := strings.TrimSpace(parts[0])
+
+	network, security, alpnStr, sni, pbk, sid, fp, path, host, serviceName := params.Get("type"), params.Get("security"), params.Get("alpn"), params.Get("sni"), params.Get("pbk"), params.Get("sid"), params.Get("fp"), params.Get("path"), params.Get("host"), params.Get("serviceName")
+
+	var alpn []string
+	if strings.Contains(alpnStr, ",") {
+		alpn = strings.Split(alpnStr, ",")
+	} else {
+		alpn = nil
+	}
+
+	enableUTLS := fp != ""
+
 	result := model.Outbound{
 		Type: "trojan",
 		Tag:  remarks,
 		TrojanOptions: model.TrojanOutboundOptions{
 			ServerOptions: model.ServerOptions{
 				Server:     server,
-				ServerPort: uint16(port),
+				ServerPort: port,
 			},
 			Password: password,
-			Network:  params.Get("type"),
+			Network:  network,
 		},
 	}
-	if params.Get("security") == "xtls" || params.Get("security") == "tls" {
-		var alpn []string
-		if strings.Contains(params.Get("alpn"), ",") {
-			alpn = strings.Split(params.Get("alpn"), ",")
-		} else {
-			alpn = nil
-		}
+
+	if security == "xtls" || security == "tls" {
 		result.TrojanOptions.OutboundTLSOptionsContainer = model.OutboundTLSOptionsContainer{
 			TLS: &model.OutboundTLSOptions{
 				Enabled:    true,
 				ALPN:       alpn,
-				ServerName: params.Get("sni"),
+				ServerName: sni,
 			},
 		}
 	}
+
 	if params.Get("security") == "reality" {
 		result.TrojanOptions.OutboundTLSOptionsContainer = model.OutboundTLSOptionsContainer{
 			TLS: &model.OutboundTLSOptions{
 				Enabled:    true,
-				ServerName: params.Get("sni"),
+				ServerName: sni,
 				Reality: &model.OutboundRealityOptions{
 					Enabled:   true,
-					PublicKey: params.Get("pbk"),
-					ShortID:   params.Get("sid"),
+					PublicKey: pbk,
+					ShortID:   sid,
 				},
 				UTLS: &model.OutboundUTLSOptions{
-					Enabled:     params.Get("fp") != "",
-					Fingerprint: params.Get("fp"),
+					Enabled:     enableUTLS,
+					Fingerprint: fp,
 				},
 			},
 		}
 	}
+
 	if params.Get("type") == "ws" {
 		result.TrojanOptions.Transport = &model.V2RayTransportOptions{
 			Type: "ws",
 			WebsocketOptions: model.V2RayWebsocketOptions{
-				Path: params.Get("path"),
+				Path: path,
 				Headers: map[string]string{
-					"Host": params.Get("host"),
+					"Host": host,
 				},
 			},
 		}
 	}
+
 	if params.Get("type") == "http" {
 		result.TrojanOptions.Transport = &model.V2RayTransportOptions{
 			Type: "http",
 			HTTPOptions: model.V2RayHTTPOptions{
-				Host: []string{params.Get("host")},
+				Host: []string{host},
 				Path: params.Get("path"),
 			},
 		}
 	}
+
 	if params.Get("type") == "quic" {
 		result.TrojanOptions.Transport = &model.V2RayTransportOptions{
 			Type:        "quic",
 			QUICOptions: model.V2RayQUICOptions{},
 		}
 	}
+
 	if params.Get("type") == "grpc" {
 		result.TrojanOptions.Transport = &model.V2RayTransportOptions{
 			Type: "grpc",
 			GRPCOptions: model.V2RayGRPCOptions{
-				ServiceName: params.Get("serviceName"),
+				ServiceName: serviceName,
 			},
 		}
 	}